Improved password reset

[mbodeantor]

Addresses #214
Reset tokens are now valid for 15 min, password reset email lists this fact
/reset-token-validation endpoint will check the reset token

Docs: https://app.gitbook.com/o/-MXypK5ySzExtEzQU6se/s/-MXyolqTg_voOhFyAcr-/~/changes/479/api/endpoints/admin

[joshuagraber]

Nice @mbodeantor ty! You good if I push the client changes in this branch as well?

[mbodeantor]

@joshuagraber For sure!

[joshuagraber]

Confirmed everything locally @mbodeantor. CC @josh-chamberlain if you want to run through the reset pw flow to test?

[josh-chamberlain]

@joshuagraber sorry, I thought of this after merging it into dev—on the reset password page, we should display the same requirements that we do on create. If you commit that to dev we can include it in #233

[joshuagraber]

@josh-chamberlain Working on this, but something is erroring on dev right now when I try to run the app, which is making it kinda hard to test.

@mbodeantor does this look familiar to you?

Traceback (most recent call last):
  File "/Users/grabes/code/pdap/data-sources-app/app.py", line 12, in <module>
    from resources.DataSources import (
  File "/Users/grabes/code/pdap/data-sources-app/resources/DataSources.py", line 4, in <module>
    from middleware.data_source_queries import data_source_by_id_query, data_sources_query
  File "/Users/grabes/code/pdap/data-sources-app/middleware/data_source_queries.py", line 78, in <module>
    ) -> tuple[Any, ...] | None:
TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'

[mbodeantor]

@maxachis

[maxachis]

@mbodeantor @joshuagraber Yep, that's a product of my type hinting causing an error. Taking a look at it right now, and should hopefully have it resolved by tomorrow if not today. This error didn't come up in my running of tests, which either means I missed a test or existing tests aren't covering this code. That may be worth making an issue about.

[maxachis]

@joshuagraber What Python version were you running on? The | should be valid for Python versions 3.10 and above, but would cause an error in 3.9 or lower.

Additionally, at the moment I do not see where a Python version is specified in the code. The tests.yaml file runs on version 3.11, so it would have missed this bug. Assuming my eyes do not deceive me (and they might), we may want to ensure the version is specified so as to avoid such issues in the future.

[mbodeantor]

@maxachis For local development, it is just based on the virtual env that is setup. In the build instructions in the README we are specifying 3.9 which as you point out does not match how we are having GitHub build, I updated the README to match.

@joshuagraber Give it a shot with a 3.11 virtualenv, also don't forget to update pdap_ds_start with the new env name!