refactor: miscellaneous updates to signin #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include snapshot for error state
Merged
joshuagraber
commented
Mar 13, 2024
| data-test="search-results-cards" | ||
| :data-source="searchResult[record.type]" | ||
| /> | ||
| <ErrorBoundary v-for="record in section.records" :key="record.type"> |
There was a problem hiding this comment.
Note: ErrorBoundary can be added anywhere. For example, in this v-for, we can stop the error from bubbling all the way up the component tree and only render the error message in the single card that failed, so the user can still interact with the rest of the UI.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates following this PR comment
Also resolves #210