Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not proxify objects that are values of non-patchable array properties #47

Merged
merged 6 commits into from
Aug 6, 2019
Merged

do not proxify objects that are values of non-patchable array properties #47

merged 6 commits into from
Aug 6, 2019

Commits on Jul 29, 2019

  1. do not proxify objects that are values of non-patchable array properties 

    because such problem happens in Vue 2 and it results in an invalid patch. See: vuejs/vue#427, vuejs/vue#9259
    @warpech
    warpech committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    24809eb View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. code quality improvement 

    as proposed by @tomalec in PR review #47 (review)
    @warpech
    warpech committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    4ac4705 View commit details
    Browse the repository at this point in the history

  2. replace "var" with "const" in the new test 

    as requested in https://github.com/Palindrom/JSONPatcherProxy/pull/47/files#r308227173
    @warpech
    warpech committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    3bc32a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. DRY verification of non-numeric array property 

    as pointed out in #47 (review)
    @warpech
    warpech committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    54e2b08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-vue-problem-with-arrays 

    # Conflicts:
#	test/spec/proxySpec.js
    @warpech
    warpech committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    61c5baf View commit details
    Browse the repository at this point in the history

  3. add missing const assignments 

    because the last merge had a conflict incorrectly resolved automatically by p4merge
    @warpech
    warpech committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    042e0d7 View commit details
    Browse the repository at this point in the history