do not proxify objects that are values of non-patchable array properties #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because such problem happens in Vue 2 and it results in an invalid patch. See: vuejs/vue#427, vuejs/vue#9259
tomalec
reviewed
Jul 29, 2019
as proposed by @tomalec in PR review #47 (review)
|
All addressed. Pleasee re-review.
I don't think so. This change is useful general and the problem is not specific only to Vue. It just happens that Vue 2 is a very high profile framework that exhibits this problem. |
tomalec
reviewed
Jul 30, 2019
src/jsonpatcherproxy.js
Outdated
| // if the new value is an object, make sure to watch it | ||
| if ( | ||
| newValue && | ||
| typeof newValue == 'object' && | ||
| !instance._treeMetadataMap.has(newValue) | ||
| ) { | ||
| instance._parenthoodMap.set(newValue, { parent: tree, key }); | ||
| newValue = instance._proxifyTreeRecursively(tree, newValue, key); | ||
| if (isTreeAnArray && !Number.isInteger(+key.toString())) { |
There was a problem hiding this comment.
cosmetic: Just for my personal readability, we could also create a const isArrayProperty = isTreeAnArray && !Number.isInteger(+key.toString()) not to repeat it here and at l.139. Slightly DRYier vs. one const variable less. If you find it readable and better this way, let's keep it :)
as pointed out in #47 (review)
# Conflicts: # test/spec/proxySpec.js
because the last merge had a conflict incorrectly resolved automatically by p4merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because such problem happens in Vue 2 and it results in an invalid patch. See: vuejs/vue#427, vuejs/vue#9259