Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer with proper vendor attribution #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented May 28, 2019

Thanks to MapBox for the Sponsorship.

Screenshot
Screenshot 2019-05-28 08 30 22

Thanks to MapBox for the Sponsorship.
@mrpollo mrpollo requested a review from bkueng May 28, 2019 15:32
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks.

<div class="col-sm-12">
<div class="copyright-text text-center">
<p>Maps brought to you by <a target="_blank" href="https://www.mapbox.com/">MapBox</a>.</p>
<p>3D Tiles and Viewer provided by <a target="_blank" href="https://www.mapbox.com/">CesiumJS</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is incorrect.

<p>Maps brought to you by <a target="_blank" href="https://www.mapbox.com/">MapBox</a>.</p>
<p>3D Tiles and Viewer provided by <a target="_blank" href="https://www.mapbox.com/">CesiumJS</a>.</p>
<p><br></p>
<p class="sm">UI Theme (Yeti) available from <a target="_blank" href="https://bootswatch.com/">Bootswatch</a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a . at the end here too, and below as well? Or remove them all, to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants