Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uorb top documentation re: Mavlink Console #2410

Open
wants to merge 2 commits into
base: v1.13
Choose a base branch
from

Conversation

msberk
Copy link

@msberk msberk commented Mar 30, 2023

Edit the uorb top documentation to reflect that the command does not work reliably in the Mavlink Console. This is in response to @AlexKlimaj's comment on Discord recently after I was unable to run uorb top over the Mavlink Console on a Pixhawk 6X running PX4 1.13.2.

If this is still applicable to main then this change should likely be applied there, too.

Edit the uorb top documentation to reflect that the command does not work reliably in the Mavlink Console
@mrpollo
Copy link
Contributor

mrpollo commented Mar 30, 2023

Hey @dagar is this a bug or expected behavior?

@msberk
Copy link
Author

msberk commented Mar 31, 2023

I guess whether it's a bug or expected behavior, it still seems like it'd be useful to note that it does not work over the Mavlink console.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Apr 5, 2023

@msberk I agree this is worth having a note and really appreciate you taking the time to add one :-).

But whether or not it is a bug or not defines what the comment looks like. For example, I like to add a bug number so that this kind of note can easily be checked and removed when the bug is fixed. The conversation with alex just says it isn't working in this case, but I can't find an open issue or bug report I can link against.

I did try this locally and it works for me over USB to a CUAV Pixhawk 6x with latest main.

Can you provide more detail. If not we can either create an issue for tracking and link it - or perhaps water-down this to "anecdotally".

@hamishwillee
Copy link
Collaborator

What I don't want to do is have an instruction that means people have to run into this problem forever. MAVLink console is too useful for this not to work.

@msberk
Copy link
Author

msberk commented Apr 5, 2023

@hamishwillee sorry if I seemed short in the reply - I misinterpreted the comment to imply that if it was expected it may not need to be edited. The bug report linking makes sense for being able to track and remove notes such as this.

Glad to hear the issue doesn't seem to exist in main on the CUAV. The hardware is a Holybro 6X, I am chasing down another issue re: low servo output rates using SBus and going to be uploading a modified 1.13.3 firmware in the next couple days anyway, so while I'm doing that I can check to see if uorb top works on main on my hardware and comment back here.

@hamishwillee
Copy link
Collaborator

That would be great. If we can get a specific reproducible case then we can create an issue and move forward.

@hamishwillee
Copy link
Collaborator

Hi @msberk Did you manage to get any further testing done on this?

@msberk
Copy link
Author

msberk commented Apr 13, 2023

Have not yet - it's on my todo list but want to make sure you know I haven't forgotten! Will update when I get to it.

@hamishwillee
Copy link
Collaborator

THanks, and no worries. I'm on other things too :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants