Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] PX4 Mainatiner Role Documentation #2313

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

junwoo091400
Copy link
Contributor

About

PX4 is introducing the maintainer role in the overall PX4 ecosystem. This adds initial documentation to give a structure on what it means & where users can find more information about them & recruitment link (TODO).

Note: This was discussed in the last Maintainers call: https://discuss.px4.io/t/px4-maintainers-call-february-21-2023/30919#maintainer-role-description-5

Files Changed

  • Initial documentation for the 'PX4 Maintainer' Role.
  • Links need to be updated when available!

- Initial documentation for the 'PX4 Maintainer' Role.
- Links need to be updated when available!
@swimmingseeds
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-maintainers-call-february-28-2023/30921/1


<!-- TODO: Add Dronecode PX4 Maintainers Role Description Link -->

To find the most up-to-date maintainers structure, visit [PX4-Autopilot README](https://github.com/PX4/PX4-Autopilot#maintenance-team). <!-- NOTE: Need to insert updated link after https://github.com/PX4/PX4-Autopilot/pull/21030 gets merged -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for merge of PX4/PX4-Autopilot#21030

@junwoo091400
Copy link
Contributor Author

junwoo091400 commented Feb 28, 2023

Note: after discusison on today's maintainers call, it was decided to:

  1. Have Maintainers role documented in the docs (not on the Dronecode website)
  2. Sign-up process will not be automated, and will be managed manually
  3. Onboarding process will be documented here as well

@mrpollo can you confirm? Confirmed

@junwoo091400 junwoo091400 marked this pull request as ready for review February 28, 2023 18:07
@hamishwillee
Copy link
Collaborator

I've subedited. Makes sense to me. I'm assuming @mrpollo will merge/approve the "technical content"

@mrpollo mrpollo changed the title PX4 Mainatiner Role Documentation [DRAFT] PX4 Mainatiner Role Documentation Mar 1, 2023
@swimmingseeds
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-maintainers-call-march-07-2023/31059/1

@hamishwillee
Copy link
Collaborator

@mrpollo Let me know when this is ready to go in/for final review by me.

@junwoo091400
Copy link
Contributor Author

@mrpollo could you check on this?

Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there @junwoo091400

The weekly maintainers call discusses overall PX4 structure, community and ecosystem.
You can find the relevant information below:

* Time: Tuesday 17h00 CET ([subscribe to calendar](https://www.dronecode.org/calendar/)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove details of the call, instead let's link to the docs where we talk about the call, because we will ultimately have too many places to update once those details change

en/contribute/maintainers.md Outdated Show resolved Hide resolved
1. Permission to merge the PR of any of PX4 workspace repositories after it's approved
2. Permission to trigger Github actions when a new contributor opens a PR.
3. Permission to edit Issue/PR contents.
3. **Dronecode member** (Junwoo/Ramon) will:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "Dronecode member"?

also please remove our names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. **Dronecode member** (Junwoo/Ramon) will:
3. **Add your info to official PX4 channels**:

1. Update the PX4 code repository [README](https://github.com/PX4/PX4-Autopilot/blob/main/README.md) to include your information.
2. Update the PX4 website [Maintainers section](https://px4.io/community/maintainers/) to include your information.
3. Add your information to the internal Dronecode database of maintainers to keep you in sync.
4. Create a social media post about your new maintainers role after a short interview.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never discussed this, let's remove for now, let's discuss and make it a reality afterwards

Copy link
Contributor

@mrpollo mrpollo Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Create a social media post about your new maintainers role after a short interview.
4. Community introduction to the new maintainer in the form of a forum post, which is promoted through ever growing official channels


### Summary

Dronecode Maintainer will lead/manage the development of a **specific category (referred as category below)** of the PX4 ecosystem. With this role, you will be at the epicenter of developing the world’s top most popular flight control software system!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dronecode Maintainer will lead/manage the development of a **specific category (referred as category below)** of the PX4 ecosystem. With this role, you will be at the epicenter of developing the world’s top most popular flight control software system!
A Dronecode Maintainer will lead/manage the development of a **specific category (referred to as category below)** of any Open Source Projects hosted within the Dronecode Foundation, such as the PX4 Autopilot.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer is a description, not a proper noun here.

Suggested change
Dronecode Maintainer will lead/manage the development of a **specific category (referred as category below)** of the PX4 ecosystem. With this role, you will be at the epicenter of developing the world’s top most popular flight control software system!
Maintainers lead/manage the development of a **specific category (referred to as category below)** of any Open Source Projects hosted within the Dronecode Foundation, such as the PX4 Autopilot.

en/contribute/maintainers.md Outdated Show resolved Hide resolved
en/contribute/maintainers.md Outdated Show resolved Hide resolved

Dronecode will provide the following tools to help you:

1. **Flight testing**: If you need a tester for your feature, we can find them and provide you with feedback/logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how we haven't been able to do this, I would remove it. Please remove line 1.

Dronecode will provide the following tools to help you:

1. **Flight testing**: If you need a tester for your feature, we can find them and provide you with feedback/logs.
2. **Release schedule**: Clear timeline of upcoming releases, feature freezes to help you decide on deciding on development process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also not doing this yet.

en/contribute/maintainers.md Outdated Show resolved Hide resolved
hamishwillee and others added 2 commits April 19, 2023 12:48
Co-authored-by: Ramon Roche <mrpollo@gmail.com>
Co-authored-by: Ramon Roche <mrpollo@gmail.com>
Co-authored-by: Ramon Roche <mrpollo@gmail.com>
@hamishwillee
Copy link
Collaborator

@mrpollo I subedited your subedits and merged them where I was happy. There are a few open actions for @junwoo091400 left, but this is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants