-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Toggle Automatic Receiver Setup #152
base: main
Are you sure you want to change the base?
Add Option to Toggle Automatic Receiver Setup #152
Conversation
Add a field to `GPSConfig` that allows disabling automatic setup of attached receivers.
This is branched from an earlier version of the main branch as branching from the head of the main branch caused compilation issues when updating the submodule in the PX4-Autopilot project (due to other changes that have happened to main). I don't know what the preferred approach is to add functionality to this repository and use it in the autopilot one without getting compilation problems from the other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it to all drivers?
This is branched from an earlier version of the main branch as branching from the head of the main branch caused compilation issues when updating the submodule in the PX4-Autopilot project (due to other changes that have happened to main). I don't know what the preferred approach is to add functionality to this repository and use it in the autopilot one without getting compilation problems from the other changes.
As long as it cleanly rebases this is fine.
I'm still getting used to the code. Would these be all the drivers that this would need to be implemented for?
Unlike for the SBF driver, I don't have access to receivers for all of the other ones, so I can't thoroughly test them. I hope that is OK? The other option would be to document that it is only supported for Septentrio receivers for now. |
Yes correct, that's ok. |
I was wondering whether this PR could be merged separately from the implementation for other drivers which could be its own PR? Implementing the bypass for Septentrio receivers is quite easy as I have access to hardware to test and the driver doesn't keep that much state. I don't have hardware for the other drivers and they keep lots of state. It would require a bigger PR, potentially with some help from others. |
For this simple change I prefer to keep them in sync right away. Once you do the change I can have a closer look. |
This adds an option to disable automatic setup of the attached receiver during the configuration. It is only implemented by the SBF driver for now. Other drivers can implement it if they want. This is linked to another PR in the PX4-Autopilot project to add a parameter that lets users disable automatic driver configuration.
@SeptentrioGNSS