Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizations in output_plots.py #923

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR does to things to make output_plots.py work better with different parameterizations:

  1. It ensures that the num_years_to_plot is less than T (or raises an assertion if not).
  2. Labels for ability types are generalized to work with any lambdas values.

Addresses Issue #757

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.47%. Comparing base (95987b7) to head (0206cd0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   73.44%   73.47%   +0.02%     
==========================================
  Files          19       19              
  Lines        4610     4637      +27     
==========================================
+ Hits         3386     3407      +21     
- Misses       1224     1230       +6     
Flag Coverage Δ
unittests 73.47% <79.31%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/output_plots.py 95.33% <79.31%> (-1.18%) ⬇️

@rickecon
Copy link
Member

This looks good to me. Thanks @jdebacker. Merging.

@rickecon rickecon merged commit 9412168 into PSLmodels:master Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants