New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix num_years_to_plot
in output_plots.plot_all
#757
Comments
@jdebacker This required changes in output_plots.py The ability_bar also needed to be changed as it was accessing constants.py to access the GROUP_LABELS for the bar plot which was hard coded. I created a function to generate the labels from the lambdas. |
@sebastiansajie I like your fixes to the I'd recommend adding the I think the changes your propose to the example script are best left out of OG-Core for now. I like having the example script produce output with a more realistic calibration, even if it does take more time to run. You can just keep your modified script around for your own use (I have a bunch of these for different simulations I've run). Let me know if you'd like to open a PR (here or at Revenue-Academy/OG-Core) or if you prefer, I can do it. |
@jdebacker, I can open a PR for 1) updates to output_plots.py and 2) Making changes to utils.py (adding lambda_labels()) in OG-Core and then eventually syncing it to Revenue Academy. |
Addressed in PR #923. |
Several of the plots in
output_plots.plot_all
assume that the time path is at least 150 periods (see here). This causes issues if a user setsT
to a value less than 150.A solution to this would be to replace
num_years_to_plot=150
tonum_years_to_plot=min(base_params.T, 150)
.The text was updated successfully, but these errors were encountered: