Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLPTW, RVH: fix the mem_resp_hit when the new req's status is changed to last_hptw_req #2983

Merged
merged 1 commit into from
May 15, 2024

Conversation

pxk27
Copy link
Contributor

@pxk27 pxk27 commented May 14, 2024

When the req is sent into LLPTW and its status need to be changed to last_hptw_req, the mem_resp_hit is not valid. It make L2TLB don't store the pte of the req. That is why L2TLB resp a wrong stage 1 pte. So the mem_resp_hit need to be valid when the new req's status is changed into last_hptw_req directly.

@pxk27 pxk27 requested a review from good-circle May 14, 2024 02:55
@pxk27 pxk27 changed the title LLPTW, RVH: fix the bug that the stage1 pte is wrong LLPTW, RVH: fix the mem_resp_hit May 14, 2024
@pxk27 pxk27 changed the title LLPTW, RVH: fix the mem_resp_hit LLPTW, RVH: fix the mem_resp_hit when the new req's status is to last_hptw_req May 14, 2024
@pxk27 pxk27 changed the title LLPTW, RVH: fix the mem_resp_hit when the new req's status is to last_hptw_req LLPTW, RVH: fix the mem_resp_hit when the new req's status is changed to last_hptw_req May 14, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: b69e21e

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
b69e21e 1.854 0.450 2.103 1.190 2.468 2.593 2.330 0.960 1.377 1.427 3.123 2.639 2.451 2.960

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0c70648 1.854 2.103 1.190 2.468 2.593 0.960 1.377 1.427 3.123 2.451 2.960
b628978 1.854 2.103 1.190 2.468 2.593 2.329 0.960 1.377 1.427 3.123 2.451 2.960
5e237ba 2.103 2.328 1.377
363530d 1.841 1.190 2.478 2.597 0.961 1.391 3.126 2.452 2.959
a72b131
05d833a 1.854 0.450 2.103 1.190 2.468 2.593 2.330 0.961 1.377 1.427 3.123 2.639 2.451 2.960
9cb05b4 0.450 2.103 2.330 1.377 2.639
4daa5bf 0.450 2.103 1.190 2.468 2.593 2.329 0.962 1.377 1.427 3.123 2.639 2.960
1e018fb 1.854 0.450 2.103 1.190 2.468 2.593 2.330 0.962 1.377 1.427 3.123 2.639 2.451 2.960
3c71816 1.854 0.450 2.103 1.190 2.468 2.593 2.330 0.962 1.377 1.427 3.123 2.639 2.451 2.960

@Tang-Haojin Tang-Haojin merged commit 7299828 into master May 15, 2024
4 checks passed
@Tang-Haojin Tang-Haojin deleted the fix-LLPTW branch May 15, 2024 01:34
Diana0525 pushed a commit to Diana0525/XiangShan that referenced this pull request May 17, 2024
… to last_hptw_req (OpenXiangShan#2983)

When the req is sent into LLPTW and its status need to be changed to
last_hptw_req, the mem_resp_hit is not valid. It make L2TLB don't store
the pte of the req. That is why L2TLB resp a wrong stage 1 pte. So the
mem_resp_hit need to be valid when the new req's status is changed into
last_hptw_req directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants