New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] Marking definitions for uploaded files (#5823) #6735
Conversation
28e2314
to
2cdbae0
Compare
2cdbae0
to
f40f982
Compare
…equired remived from upload forms (#5823)
f40f982
to
d6ba8f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
+ Coverage 68.06% 68.59% +0.52%
==========================================
Files 538 545 +7
Lines 65801 66485 +684
Branches 5578 6527 +949
==========================================
+ Hits 44786 45603 +817
+ Misses 21015 20882 -133 ☔ View full report in Codecov by Sentry. |
File marking resolution in Content tab of an entity with file creation doesn't work |
Additionnaly : we are missing default file marking of entity when missing + we need to check the importFiles |
...atform/opencti-front/src/private/components/common/files/FileImportMarkingSelectionPopup.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/common/files/FileUploader.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/common/files/FileUploader.tsx
Outdated
Show resolved
Hide resolved
I've done some tests with a Malware and the Stix json export.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are changing uploadImport mutation, it could be great to add at least one resolver test that covers it.
...atform/opencti-front/src/private/components/common/files/FileImportMarkingSelectionPopup.tsx
Outdated
Show resolved
Hide resolved
I've tested the upload, access check is OK. |
There is no resolver tests for file domain yet. This would require significant work, let's split this in another PR. |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...