Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] missing opts definition file_marking for file upload(#5548) #6868

Merged
merged 2 commits into from
May 2, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented May 2, 2024

Proposed changes

  • Missing a opts definition in file-storage-helper.

Related issues

Small left over between 2 PRs:

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aHenryJard aHenryJard marked this pull request as ready for review May 2, 2024 14:46
@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (d6fc1aa) to head (5ef91bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6868   +/-   ##
=======================================
  Coverage   67.94%   67.94%           
=======================================
  Files         553      553           
  Lines       67171    67172    +1     
  Branches     5657     5657           
=======================================
+ Hits        45637    45640    +3     
+ Misses      21534    21532    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae merged commit 4f445d5 into master May 2, 2024
5 checks passed
@Kedae Kedae deleted the issue/5548-marking branch May 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants