Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import dependencies from VCPKG by default on Windows. #869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emptyVoid
Copy link
Contributor

Here's a proposal to import uncustomised dependency libraries from VCPKG instead of building them from sources. Importing is enabled by default on Windows and could be enabled via USE_VCPKG_* options on other platforms, the same options could be used to disable importing on Windows.

Resolves #866.

@JonnyH
Copy link
Collaborator

JonnyH commented May 13, 2020

I'm unsure if this is actually needed going forward - we need the sources for other platforms already, and I personally like having sources locally to aid debugging into libraries - maybe there's something wrong with my setup but it doesn't seem to do source-level debugging with vcpkg-imported libraries.

@emptyVoid
Copy link
Contributor Author

Have you tried updating vcpkg?
I've just tested stepping into pugi::xml_document::load_file -- works as expected.

@FilmBoy84 FilmBoy84 added WIP Work In Progress. This is not a complete feature/fix. Check it out, maybe you have something to add? STALLED Work In Progress but for whatever reason, nothing's been done for a while. New coders may be needed! labels Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STALLED Work In Progress but for whatever reason, nothing's been done for a while. New coders may be needed! WIP Work In Progress. This is not a complete feature/fix. Check it out, maybe you have something to add?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are dependencies required to be built from sources?
3 participants