Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selling a vehicle causes a crash #928

Open
Jarskih opened this issue Aug 3, 2020 · 3 comments
Open

Selling a vehicle causes a crash #928

Jarskih opened this issue Aug 3, 2020 · 3 comments
Labels
!BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Vehicle ID Error A label for tracking all issues relating to this long standing Vehicle/UFO related crash Verified / Replicated This issue has been verified or replicated by a developer

Comments

@Jarskih
Copy link
Contributor

Jarskih commented Aug 3, 2020

Steps to reproduce:

  • Start a new game.
  • Sell vehicle while the game is paused.
  • Save the game.
  • Load the game.
  • All vehicles has been replaced with copies of one type of vehicle (hover cars in my case).
  • Unpause the game and wait for a while.

vehicle->die() is used in the buildsellscreen::executeOrders() method which is probably causing this bug. This happens also before the latest fix for destroyed bases.

Error message:
"OpenApoc::StateRef::resolve(void) const: No Vehicle object matching ID "VEHICLE_19" found"
@makus82 makus82 added the !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! label Aug 3, 2020
@makus82
Copy link
Contributor

makus82 commented Aug 3, 2020 •
edited

its at 2a5bcd6 ??

im at and cant reproduce

Merge pull request #916 from idshibanov/extract_economy_data
0.0.246
3 days ago by FilmBoy84 (committed by GitHub)
master ae1deb1

@makus82
Copy link
Contributor

makus82 commented Aug 3, 2020

yes get that bug at 2a5bcd6

This was referenced Oct 26, 2021
Open
Open
@FilmBoy84 FilmBoy84 added Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Vehicle ID Error A label for tracking all issues relating to this long standing Vehicle/UFO related crash Verified / Replicated This issue has been verified or replicated by a developer labels Oct 26, 2021
@FilmBoy84
Copy link
Collaborator

I can no longer recreate this crash by the method shown in the OP
However, the vehicle ID problems still appear and still continue to be related to destruction or sale of vehicles so leaving open

Please see also

#991
#987
#940
#931
#928
#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Vehicle ID Error A label for tracking all issues relating to this long standing Vehicle/UFO related crash Verified / Replicated This issue has been verified or replicated by a developer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jarskih @makus82 @FilmBoy84