Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are dependencies required to be built from sources? #866

Open
emptyVoid opened this issue May 8, 2020 · 2 comments · May be fixed by #869
Open

Are dependencies required to be built from sources? #866

emptyVoid opened this issue May 8, 2020 · 2 comments · May be fixed by #869
Labels
Code Query Something doesn't seem right in the code. It may not be a bug, but it probably needs fixing! Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! Question This is a question relating to OpenApoc or it's code

Comments

@emptyVoid
Copy link
Contributor

From 8 dependency libraries found in dependencies 6 are available through vcpkg (except libsmacker and tinyformat).

Does OpenApoc use some custom/specific versions of those libraries and thus cannot import them from vcpkg?

If not I'd like to switch to vcpkg to reduce compilation times.
@JonnyH
Copy link
Collaborator

JonnyH commented May 8, 2020

Some use custom patched versions (like libsmacker and physfs), some require pinned versions (while I think we can now use the latest version of glm, there's been some api changes that we've had to workaround)

Also the dependencies/ directory was created before vcpkg was a thing, and on some platforms that already have system package managers (e.g. most Linux distros) vcpkg isn't really a good solution globally.

@emptyVoid
Copy link
Contributor Author

Yeah, I realize vcpkg is mostly used on Windows only.

It's just the development on Windows could benefit from importing packages from vcpkg instead of building where possible. And IMO this stands for other platforms too -- resorting to building a package from sources only when the native package is not available or is unsuitable.

@emptyVoid emptyVoid linked a pull request May 13, 2020 that will close this issue
Open
@FilmBoy84 FilmBoy84 added Code Query Something doesn't seem right in the code. It may not be a bug, but it probably needs fixing! Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! Question This is a question relating to OpenApoc or it's code labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Query Something doesn't seem right in the code. It may not be a bug, but it probably needs fixing! Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! Question This is a question relating to OpenApoc or it's code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import dependencies from VCPKG by default on Windows. emptyVoid/OpenApoc
3 participants
@JonnyH @emptyVoid @FilmBoy84