-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outlook] (quickstart) update unified manifest quickstart #4341
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9d1adb6
[Outlook] (quickstart) update unified manifest quickstart
Rick-Kirkham 2b4f8cd
a single quickstart for both manifests
Rick-Kirkham fbb1ddc
fix build warnings
Rick-Kirkham 8057d19
add unified manifest value proposition and feedback request
Rick-Kirkham 9932bc8
Apply suggestions from code review
Rick-Kirkham f5d6b48
make 'Explore the project' section manifest-agnostic
Rick-Kirkham 30d1f91
Update outlook-quickstart-json-manifest-typescript.md
Rick-Kirkham 08c038e
Resolving merge conflicts
Rick-Kirkham b0e6c4b
metadata date
Rick-Kirkham 6c30f8d
resolve merge conflicts
Rick-Kirkham File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't leave a comment directly on the affected section, so adding this here.
Lines 61 - 66 ("Explore the project"): Include the file structure of an add-in project that uses the unified manifest (see Explore the project).
Line 68 ("Update the code"): We may need to add a note specifying that this section only applies to projects that use the XML manifest. I have a to-do to incorporate this JS code into the Outlook Yo Office template, but I might not be able to complete the work in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the Explore the project section.
The Update the code section applies regardless of the type of manifest that they chose.
Darren and I have already updated the task pane project for JavaScript so that the user can choose either language with either type of manifest. I'm not clear on what your ToDo is, but I don't think it's needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ricky.
Ah, I forgot that the change you and Darren worked on included language selection. Thanks for clearing that up. My task involves adding the JS code in the "Update the code" section of the Outlook quick start to the Outlook Yo Office template, so that the user can run the add-in right after creating it. This would align the Outlook quick start with the other quick starts, such as Excel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I think I get it now. Step 3 of the "Update the code" section would be deleted because that code would be in the project when it is created.