[Outlook] (quickstart) update unified manifest quickstart #4341
Conversation
|
Learn Build status updates of commit 9d1adb6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 2b4f8cd:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/develop/json-manifest-overview.md | View | Details | |
| docs/develop/unified-manifest-overview.md | View | Details | |
| docs/outlook/index.yml | View | Details | |
| docs/quickstarts/outlook-quickstart-json-manifest.md | n/a (file deleted or renamed) | Details | |
| docs/excludes/outlook-quickstart-json-manifest-typescript.md | ✅Succeeded | ||
| docs/images/yo-office-outlook-json-manifest-javascript.png | ✅Succeeded | View | |
| docs/images/yo-office-outlook-json-manifest-typescript.png | ✅Succeeded | View | |
| docs/images/yo-office-outlook-xml-manifest-javascript.png | ✅Succeeded | View | |
| docs/quickstarts/outlook-quickstart.md | ✅Succeeded | View | |
| docs/toc.yml | ✅Succeeded | View |
docs/develop/json-manifest-overview.md
- Line 108, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../quickstarts/outlook-quickstart-json-manifest.md'.
docs/develop/unified-manifest-overview.md
- Line 32, Column 70: [Warning: file-not-found - See documentation]
Invalid file link: '../quickstarts/outlook-quickstart-json-manifest.md'.
docs/outlook/index.yml
- Line 31, Column 18: [Warning: file-not-found - See documentation]
Invalid file link: '../quickstarts/outlook-quickstart-json-manifest.md'.
docs/quickstarts/outlook-quickstart-json-manifest.md
- [Warning: file-not-redirected - See documentation]
File docs/quickstarts/outlook-quickstart-json-manifest.md with URL /office/dev/add-ins/quickstarts/outlook-quickstart-json-manifest was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
Learn Build status updates of commit fbb1ddc: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
I'm redoing the PR for the quick starts. Because we're adding support for JavaScript with the unified manifest (that development is probably an email that I scheduled-sent for later this week), we'll have just one quick start and the user will be instructed to choose JavaScript and then their choice of XML or unified manifest. The existing unified manifest quick start is moving the /excludes folder. See this PR: #4341 |
Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com>
|
Learn Build status updates of commit 8057d19: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 9932bc8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
|
||
|  | ||
|
|
||
|  | ||
|
|
||
| After you complete the wizard, the generator will create the project and install supporting Node components. | ||
|
|
There was a problem hiding this comment.
I can't leave a comment directly on the affected section, so adding this here.
Lines 61 - 66 ("Explore the project"): Include the file structure of an add-in project that uses the unified manifest (see Explore the project).
Line 68 ("Update the code"): We may need to add a note specifying that this section only applies to projects that use the XML manifest. I have a to-do to incorporate this JS code into the Outlook Yo Office template, but I might not be able to complete the work in time.
There was a problem hiding this comment.
I updated the Explore the project section.
The Update the code section applies regardless of the type of manifest that they chose.
Darren and I have already updated the task pane project for JavaScript so that the user can choose either language with either type of manifest. I'm not clear on what your ToDo is, but I don't think it's needed.
There was a problem hiding this comment.
Thanks, Ricky.
Ah, I forgot that the change you and Darren worked on included language selection. Thanks for clearing that up. My task involves adding the JS code in the "Update the code" section of the Outlook quick start to the Outlook Yo Office template, so that the user can run the add-in right after creating it. This would align the Outlook quick start with the other quick starts, such as Excel.
There was a problem hiding this comment.
Thanks, Ricky.
Ah, I forgot that the change you and Darren worked on included language selection. Thanks for clearing that up. My task involves adding the JS code in the "Update the code" section of the Outlook quick start to the Outlook Yo Office template, so that the user can run the add-in right after creating it. This would align the Outlook quick start with the other quick starts, such as Excel.
OK. I think I get it now. Step 3 of the "Update the code" section would be deleted because that code would be in the project when it is created.
|
Learn Build status updates of commit f5d6b48: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 30d1f91: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 08c038e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit b0e6c4b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 6c30f8d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
These changes make the following assumptions:
The quick start has been edited so it will work for either manifest.
The special quick start for the unified manifest, that used TypeScript, has been moved to the "/excludes" folder in case we ever want to use it again. It has been removed from the ToC.