Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdePackages.mkKdeDerivation: fix meta.pos #297780

Closed

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 21, 2024

This reverts commit efdbcac.

The previous behaviour was correct and can be tested with: nix edit kdePackages.ark

#297740 (comment)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@K900
Copy link
Contributor

K900 commented Mar 21, 2024

Something is wrong here, because if we do it this way, meta.broken gets ignored instead.

@SuperSandro2000 SuperSandro2000 changed the title Revert "kdePackages.mkKdeDerivation: fix meta operator priority" kdePackages.mkKdeDerivation: fix meta.pos Mar 21, 2024
@SuperSandro2000
Copy link
Member Author

I've pushed a change which instead inherits first meta and fixes meta.pos in a second merge. I think that should work.

@K900
Copy link
Contributor

K900 commented Mar 21, 2024

#297783 seems like it also works, and is a lot simpler

@K900
Copy link
Contributor

K900 commented Mar 21, 2024

Merged that.

@K900 K900 closed this Mar 21, 2024
@SuperSandro2000 SuperSandro2000 deleted the mkKdeDerivation branch March 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants