kde/gear: 24.02.0 -> 24.02.1 #297740
Merged
kde/gear: 24.02.0 -> 24.02.1 #297740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
ilya-fedin,
LunNova,
SuperSandro2000,
NickCao,
mjm and
ttuegel
mjm
approved these changes
Mar 21, 2024
|
Result of 69 packages marked as broken and skipped:
700 packages built:
|
| @@ -124,4 +124,4 @@ in | |||
| position = "${pos.file}:${toString pos.line}"; | |||
| } // (args.meta or { }); | |||
| in | |||
| stdenv.mkDerivation (defaultArgs // cleanArgs) // { inherit meta; } | |||
| stdenv.mkDerivation (defaultArgs // cleanArgs // { inherit meta; }) | |||
There was a problem hiding this comment.
I don't think that is correct. To apply meta.pos correctly, it needs to be merged after mkDerivation got evaluated. When I do nix edit kdePackages.ark on this branch, this file gets opened, instead of pkgs/kde/gear/ark/default.nix like on nixos-unstable currently.
There was a problem hiding this comment.
But doing it the other way around breaks meta.broken.
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://kde.org/announcements/gear/24.02.1/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.