Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{uid,nss,socket,resolv}_wrapper: fix meta description & homepage, add changelog #284567

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

{uid,nss,socket,resolv}_wrapper: fix meta description & homepage, add changelog #284567

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cec599
resolv_wrapper: fix meta description & homepage
phaer Jan 28, 2024
7e1a677
resolv_wrapper: add meta.changelog
phaer Jan 29, 2024
6dfc84e
uid_wrapper: fix description
phaer Jan 29, 2024
0cffa21
uid_wrapper: add changelog
phaer Jan 29, 2024
1628743
socket_wrapper: add changelog
phaer Jan 29, 2024
2199446
nss_wrapper: add changelog
phaer Jan 29, 2024
6e7d536
uid_wrapper: link to version-specific changelog
phaer Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/development/libraries/nss_wrapper/default.nix
View file
Open in desktop
Expand Up @@ -17,5 +17,6 @@ stdenv.mkDerivation rec {
license = licenses.bsd3;
platforms = platforms.unix;
broken = stdenv.isDarwin;
changelog = "https://git.samba.org/?p=nss_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD";
};
}
5 changes: 3 additions & 2 deletions pkgs/development/libraries/resolv_wrapper/default.nix
View file
Open in desktop
Expand Up @@ -12,9 +12,10 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [ cmake pkg-config ];

meta = with lib; {
description = "A wrapper for the user, group and hosts NSS API";
homepage = "https://git.samba.org/?p=uid_wrapper.git;a=summary;";
description = "A wrapper for DNS name resolving or DNS faking";
homepage = "https://git.samba.org/?p=resolv_wrapper.git;a=summary;";
license = licenses.bsd3;
platforms = platforms.linux;
changelog = "https://git.samba.org/?p=resolv_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD";
};
}
1 change: 1 addition & 0 deletions pkgs/development/libraries/socket_wrapper/default.nix
View file
Open in desktop
Expand Up @@ -16,5 +16,6 @@ stdenv.mkDerivation rec {
homepage = "https://git.samba.org/?p=socket_wrapper.git;a=summary;";
license = licenses.bsd3;
platforms = platforms.all;
changelog = "https://git.samba.org/?p=socket_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD";
};
}
3 changes: 2 additions & 1 deletion pkgs/development/libraries/uid_wrapper/default.nix
View file
Open in desktop
Expand Up @@ -12,9 +12,10 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [ cmake pkg-config ];

meta = with lib; {
description = "A wrapper for the user, group and hosts NSS API";
description = "A testing tool to fake privilege separation";
homepage = "https://git.samba.org/?p=uid_wrapper.git;a=summary;";
license = licenses.bsd3;
platforms = platforms.all;
changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD";
changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=refs/tags/uid_wrapper-${version}";

We should link the changelog of the specific commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't wrote this out explicit but I think all the other meta.changelog changes should get the same change.

Copy link
Member Author

@phaer phaer Mar 31, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to fix it - should take a similar amount of time as the comments written about this so far :)

I intended to do a quick fix as I noticed that package descriptions were copied wrongly. The fact that this went unnoticed since the packages introduction in nixpkgs 9 years ago makes me question how urgent it is to link to individual releases for the changelogs. ;)

};
}