{uid,nss,socket,resolv}_wrapper: fix meta description & homepage, add changelog #284567
Conversation
Those where seemingly copied over from uid_wrapper by mistake.
(mistakenly copied from nss_wrapper)
phaer
changed the title
|
@dotlambda I think, as a maintainer you could even add that directly? Added meta.changelog to all of those samba cwrap wrappers. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3684 |
| homepage = "https://git.samba.org/?p=uid_wrapper.git;a=summary;"; | ||
| license = licenses.bsd3; | ||
| platforms = platforms.all; | ||
| changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD"; |
There was a problem hiding this comment.
| changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=HEAD"; | |
| changelog = "https://git.samba.org/?p=uid_wrapper.git;a=blob;f=CHANGELOG;hb=refs/tags/uid_wrapper-${version}"; |
We should link the changelog of the specific commit
There was a problem hiding this comment.
I didn't wrote this out explicit but I think all the other meta.changelog changes should get the same change.
There was a problem hiding this comment.
Feel free to fix it - should take a similar amount of time as the comments written about this so far :)
I intended to do a quick fix as I noticed that package descriptions were copied wrongly. The fact that this went unnoticed since the packages introduction in nixpkgs 9 years ago makes me question how urgent it is to link to individual releases for the changelogs. ;)
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Description and homepage where seemingly copied over from uid_wrapper by mistake.
Also, add meta.changelog to all of the packaged samba wrappers.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.