hap-py: init 0.3.15 #283881
Merged
hap-py: init 0.3.15 #283881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apraga
force-pushed
the
hap-py-0.3.15
branch
from
3e3b354
to
de9d5e5
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3701 |
SuperSandro2000
requested changes
Mar 28, 2024
apraga
force-pushed
the
hap-py-0.3.15
branch
2 times, most recently
from
28be50e
to
40e9f60
Compare
|
Thanks for your helpful review ! The derivation has been improved to match your suggestions (except the one waiting on |
New package for genetics : helps compared variants called by a pipeline to a reference. The only tests not passing are due to a difference in float representation (same value but with different number of digits after decimal).
For best results (quality and running time), the authors advice to use RTGtools vcfeval as the engine. Depends on NixOS#230394
|
PR needed for this PR has been merged (thanks !). If you are OK with this PR, could you merge it too ? |
SuperSandro2000
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New package for genetics : helps compared variants called by a pipeline to a reference.
The only tests not passing are due to a difference in float representation (same value but with
different number of digits after decimal).
For best results (quality and running time), the
authors advice to use RTGtools vcfeval as the
engine. So this package requires #230394
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.