Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update trailing character cleanup regex in FlexibleDateTimeParser #763

Merged
merged 5 commits into from May 10, 2024
Merged

update trailing character cleanup regex in FlexibleDateTimeParser #763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
348d21f
update trailing character cleanup regex in FlexibleDateTimeParser
jpdahlke Apr 26, 2024
2b3cf6f
remove match restriction
jpdahlke Apr 26, 2024
c92cfed
add length limit on date value
jpdahlke Apr 26, 2024
789f4e1
reorder checks
jpdahlke Apr 26, 2024
bec58d2
Revert "reorder checks"
jpdahlke Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/emissary/util/FlexibleDateTimeParser.java
View file
Open in desktop
Expand Up @@ -51,7 +51,7 @@
private static final Pattern REPLACE = Pattern.compile("\t+|[ ]+", Pattern.DOTALL);

/* Remove other junk */
private static final Pattern REMOVE = Pattern.compile("<.+?>|=0D$", Pattern.DOTALL);
private static final Pattern REMOVE = Pattern.compile("<.+?>$|=0D$", Pattern.DOTALL);

/* timezone - config var: TIMEZONE */
private static ZoneId timezone = ZoneId.of(DEFAULT_TIMEZONE);
Expand Down Expand Up @@ -227,7 +227,7 @@

String cleanedDateString = date;
cleanedDateString = REPLACE.matcher(cleanedDateString).replaceAll(SPACE);
cleanedDateString = REMOVE.matcher(cleanedDateString).replaceAll(EMPTY);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on a
user-provided value
may run slow on strings starting with '<' and with many repetitions of '<'.
return StringUtils.trimToNull(cleanedDateString);
}

Expand Down
1 change: 1 addition & 0 deletions src/test/java/emissary/util/FlexibleDateTimeParserTest.java
View file
Open in desktop
Expand Up @@ -420,6 +420,7 @@ void parse_yyyy_DDD() {
@Test
void testCleanDateString() {
test("2016-01-04 18:20<br>", EXPECTED_NO_SECS, "HTML");
test("2016-01-04 18:20<br>br>", EXPECTED_NO_SECS, "HTML");
jpdahlke marked this conversation as resolved.
Show resolved Hide resolved
test("2016-01-04\t\t18:20", EXPECTED_NO_SECS, "TABS");
test("2016-01-04 18:20", EXPECTED_NO_SECS, "SPACES");
test("2016-01-04 18:20=0D", EXPECTED_NO_SECS, "qp'ified ending");
Expand Down