update trailing character cleanup regex in FlexibleDateTimeParser #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdahlke
commented
Apr 26, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit 789f4e1.
|
I believe the CodeQL issue has been addressed adequately but the scan does not seem to acknowledge the newly imposed length limitation. I have dismissed it as a false positive, but if anyone disagrees with that I can re-open it. |
|
I created the following PR in an attempt to address the Sonar rule violation. #769 |
fbruton
approved these changes
May 3, 2024
arp-0984
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rules.sonarsource.com/java/RSPEC-5850/
https://github.com/NationalSecurityAgency/emissary/security/code-scanning/58