Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): upgrade knex #1868

Merged
merged 3 commits into from Mar 18, 2024
Merged

fix(deps): upgrade knex #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab4f3f
fix(deps): upgrade knex
bodinsamuel Mar 18, 2024
62236ed
remove leftover
bodinsamuel Mar 18, 2024
0d4f359
Merge branch 'master' into fix/upgrade-knex
bodinsamuel Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 21 additions & 32 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jobs/package.json
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@
"dotenv": "^16.0.3",
"fs-extra": "^11.1.1",
"js-yaml": "^4.1.0",
"knex": "^2.4.2",
"knex": "3.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a major upgrade. Are we fully confident upgrading doesn't break anythin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main breaking change is the drop of Node16 and some small types fixes
https://github.com/knex/knex/releases/tag/3.0.0

But I would love to test on staging before merging

"md5": "^2.3.0",
"nanoid": "3.x",
"node-cron": "3.0.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/server/package.json
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@
"@hapi/boom": "^10.0.1",
"@nangohq/shared": "^0.39.5",
"axios": "^1.3.4",
"connect-session-knex": "^3.0.1",
"connect-session-knex": "4.0.0",
"cookie-parser": "^1.4.6",
"cors": "^2.8.5",
"dd-trace": "5.2.0",
Expand All @@ -36,7 +36,7 @@
"form-data": "^4.0.0",
"js-yaml": "^4.1.0",
"jsonwebtoken": "^9.0.2",
"knex": "^2.3.0",
"knex": "3.1.0",
"mailgun.js": "^8.2.1",
"multer": "^1.4.5-lts.1",
"node-cron": "^3.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@
"ip": "^2.0.1",
"js-yaml": "^4.1.0",
"jsonwebtoken": "^9.0.2",
"knex": "^2.3.0",
"knex": "3.1.0",
"lodash-es": "^4.17.21",
"md5": "^2.3.0",
"ms": "3.0.0-canary.1",
Expand Down