fix(deps): upgrade knex #1868
Merged
fix(deps): upgrade knex #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
requested review from
khaliqgant and
TBonnin
and removed request for
khaliqgant
TBonnin
reviewed
Mar 18, 2024
| @@ -29,7 +30,7 @@ | |||
| "dotenv": "^16.0.3", | |||
| "fs-extra": "^11.1.1", | |||
| "js-yaml": "^4.1.0", | |||
| "knex": "^2.4.2", | |||
| "knex": "3.1.0", | |||
There was a problem hiding this comment.
it is a major upgrade. Are we fully confident upgrading doesn't break anythin?
There was a problem hiding this comment.
the main breaking change is the drop of Node16 and some small types fixes
https://github.com/knex/knex/releases/tag/3.0.0
But I would love to test on staging before merging
|
Looks good on staging 👌🏻 |
TBonnin
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes NAN-594