Switch rmm device_memory_resource to device_async_resource_ref #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
|
build |
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
|
build |
|
build |
ttnghia
reviewed
May 16, 2024
src/main/cpp/src/bloom_filter.cu
Outdated
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| #include <rmm/cuda_stream_view.hpp> | |||
| #include <rmm/exec_policy.hpp> | |||
| #include <rmm/resource_ref.hpp> | |||
There was a problem hiding this comment.
Including the header in cu file is redundant, since we already did that in the header of this source file (bloom_filter.hpp).
This is applied for all other source files.
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
Signed-off-by: Paul Mattione <pmattione@nvidia.com>
|
build |
1 similar comment
|
build |
|
build |
2 similar comments
|
build |
|
build |
ttnghia
approved these changes
May 22, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the soon-to-be-removed rmm device_memory_resource to device_async_resource_ref. However this PR does not update the resource adaptor, as that solution is not ready yet.