-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Angular v17 #8151
Conversation
This preview will be available after the AzureCI is passed. |
test error maybe need support standalone #8095 |
@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released |
yes. i think we need waitting |
Mmh il will try to update ngx-qwicklink today |
I have submitted a PR :) |
Awesome work ! Thanks a lot |
Does the new build support? ( |
I'm looking forward |
i currently do not plan to support it. But in the future, I will try to remove webpack |
1ebf234
to
6c35eed
Compare
can't wait 😀 |
package.json
Outdated
@@ -25,41 +25,40 @@ | |||
"prepare": "husky install" | |||
}, | |||
"dependencies": { | |||
"@angular/cdk": "^16.2.1", | |||
"@angular/cdk": "^17.0.0", | |||
"@ant-design/icons-angular": "^16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8151 +/- ##
==========================================
- Coverage 91.69% 91.69% -0.01%
==========================================
Files 517 517
Lines 17806 17810 +4
Branches 2728 2730 +2
==========================================
+ Hits 16328 16331 +3
- Misses 1179 1180 +1
Partials 299 299 ☔ View full report in Codecov by Sentry. |
是否有任何方案可以让 zorro 摆脱 custom webpack ? |
目前这用在了测试上,因为支持了 antd v4 less 变量 root-entry-name,我们后面需要探索是否可以使用自带的 fileReplacements 来实现脱离 custom webpack |
7554e99
to
9e2ab6b
Compare
855f904
to
86ce4e1
Compare
f340845
to
5d1c183
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #8142
What is the new behavior?
Does this PR introduce a breaking change?
Other information