Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Angular v17 #8151

Merged
merged 2 commits into from
Nov 16, 2023
Merged

chore: update Angular v17 #8151

merged 2 commits into from
Nov 16, 2023

Conversation

MunMunMiao
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: #8142

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

zorro-bot bot commented Nov 7, 2023

This preview will be available after the AzureCI is passed.

@MunMunMiao MunMunMiao changed the title update Angular v17.0.0-rc.4 update Angular v17.0.0 Nov 7, 2023
@MunMunMiao MunMunMiao changed the title update Angular v17.0.0 update Angular v17 Nov 7, 2023
@MunMunMiao MunMunMiao changed the title update Angular v17 chore: update Angular v17 Nov 8, 2023
@MunMunMiao
Copy link
Collaborator Author

test error maybe need support standalone #8095

.eslintrc.js Show resolved Hide resolved
@Nicoss54
Copy link
Collaborator

Nicoss54 commented Nov 9, 2023

@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released

@MunMunMiao
Copy link
Collaborator Author

@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released

yes. i think we need waitting ngx-qwicklink and ant-design/angular-icons and @angular-builders/custom-webpack

@Nicoss54
Copy link
Collaborator

Nicoss54 commented Nov 9, 2023

@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released

yes. i think we need waitting ngx-qwicklink and ant-design/angular-icons and @angular-builders/custom-webpack

Mmh il will try to update ngx-qwicklink today

@MunMunMiao
Copy link
Collaborator Author

@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released

yes. i think we need waitting ngx-qwicklink and ant-design/angular-icons and @angular-builders/custom-webpack

Mmh il will try to update ngx-qwicklink today

I have submitted a PR :)

@Nicoss54
Copy link
Collaborator

Nicoss54 commented Nov 9, 2023

@MunMunMiao i think the dependencies ngx-qwicklink and ant-design/angular-icons should be updated when it will be released. Alors because test use customwebpack/buiders package this dependencies need to be update too when it will be released

yes. i think we need waitting ngx-qwicklink and ant-design/angular-icons and @angular-builders/custom-webpack

Mmh il will try to update ngx-qwicklink today

I have submitted a PR :)

Awesome work ! Thanks a lot

@simplejason simplejason mentioned this pull request Nov 9, 2023
@MarcosPaulo775
Copy link

Does the new build support? (@angular-devkit/build-angular:browser-esbuild and @angular-devkit/build-angular:application)

@nguyendkn
Copy link

I'm looking forward

@MunMunMiao
Copy link
Collaborator Author

MunMunMiao commented Nov 10, 2023

Does the new build support? (@angular-devkit/build-angular:browser-esbuild and @angular-devkit/build-angular:application)

i currently do not plan to support it. But in the future, I will try to remove webpack

@MunMunMiao MunMunMiao force-pushed the feat/v17 branch 3 times, most recently from 1ebf234 to 6c35eed Compare November 13, 2023 06:18
@Ninja4Panda
Copy link

can't wait 😀

package.json Outdated Show resolved Hide resolved
package.json Outdated
@@ -25,41 +25,40 @@
"prepare": "husky install"
},
"dependencies": {
"@angular/cdk": "^16.2.1",
"@angular/cdk": "^17.0.0",
"@ant-design/icons-angular": "^16.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MunMunMiao
Copy link
Collaborator Author

now custom webpack and icons angular have been upgraded to v17

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2d971e) 91.69% compared to head (0b25916) 91.69%.
Report is 1 commits behind head on master.

❗ Current head 0b25916 differs from pull request most recent head 5d1c183. Consider uploading reports for the commit 5d1c183 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8151      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         517      517              
  Lines       17806    17810       +4     
  Branches     2728     2730       +2     
==========================================
+ Hits        16328    16331       +3     
- Misses       1179     1180       +1     
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119
Copy link
Collaborator

是否有任何方案可以让 zorro 摆脱 custom webpack ?

@simplejason
Copy link
Member

是否有任何方案可以让 zorro 摆脱 custom webpack ?

目前这用在了测试上,因为支持了 antd v4 less 变量 root-entry-name,我们后面需要探索是否可以使用自带的 fileReplacements 来实现脱离 custom webpack

components/package.json Outdated Show resolved Hide resolved
@MunMunMiao MunMunMiao force-pushed the feat/v17 branch 2 times, most recently from 855f904 to 86ce4e1 Compare November 15, 2023 12:40
@Nicoss54 Nicoss54 self-requested a review November 15, 2023 21:05
@simplejason simplejason merged commit 4e9f876 into NG-ZORRO:master Nov 16, 2023
7 checks passed
@MunMunMiao MunMunMiao deleted the feat/v17 branch November 16, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants