Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 support #8142

Closed
maratkalibek opened this issue Nov 1, 2023 · 19 comments
Closed

Angular 17 support #8142

maratkalibek opened this issue Nov 1, 2023 · 19 comments

Comments

@maratkalibek
Copy link

What problem does this feature solve?

In November 2023 Angular 17 will be released. What ETA for ng-zorro-antd support for Angular 17?
Thanks for supporting this project.

What does the proposed API look like?

Support of angular 17

@ParsaArvanehPA
Copy link
Contributor

ParsaArvanehPA commented Nov 2, 2023

Every new angular version is in beta for the first 3 months, and then will be tagged LTS after that.
Normally libraries wait for the new version to be LTS and then release a version for it.
Same happed with the angular 16, so if they stick to their routine, expect ng-zorro to release it's 17 version in mid February.

Copy link

zorro-bot bot commented Nov 3, 2023

Hello @maratkalibek. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @maratkalibek, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@MunMunMiao
Copy link
Collaborator

plz support

@dylanvdmerwe
Copy link

dylanvdmerwe commented Nov 6, 2023

This is the only library that makes us wait 3 months after a release before we can use the latest Angular version. What can be done so that this is more seamless and is ready at launch of Angular 17?

@MunMunMiao
Copy link
Collaborator

ant-design-icons: ant-design/ant-design-icons#606

@Credo-Zhao
Copy link

I'm fine with a three-month delay.
In prod env, stability first.
Hope this library can continue to be updated for a long time.

@simplejason
Copy link
Member

simplejason commented Nov 9, 2023

17.0.0-beta.0 is now available, you can try it first if you are interested. The17.0.0 version is expected to be released next week.
PR related: #8151

@simplejason simplejason pinned this issue Nov 9, 2023
@maratkalibek
Copy link
Author

Thank you for supporting this library!

@s-triar
Copy link

s-triar commented Nov 16, 2023

17.0.0-beta.0 is now available, you can try it first if you are interested. The17.0.0 version is expected to be released next week. PR related: #8151

after using this version of ng zorro, I encounter many issue regarding hydration and still not work when using new control flow @for

@MunMunMiao
Copy link
Collaborator

17.0.0-beta.0 is now available, you can try it first if you are interested. The17.0.0 version is expected to be released next week. PR related: #8151

after using this version of ng zorro, I encounter many issue regarding hydration and still not work when using new control flow @for

Can you provide a minimum viewing example?

@maratkalibek
Copy link
Author

Thanks a lot for releasing version with Angular 17 support!

@maratkalibek
Copy link
Author

17.0.0-beta.0 is now available, you can try it first if you are interested. The17.0.0 version is expected to be released next week. PR related: #8151

after using this version of ng zorro, I encounter many issue regarding hydration and still not work when using new control flow @for

Can you provide a minimum viewing example?

I think you can create new issue for this problem.

@qyjs
Copy link

qyjs commented Nov 23, 2023

ng-17-antd@0.0.0 build D:\WEB\Angular\ng-17-antd

ng build

⠇ Building...▲ [WARNING] Deprecated inline execution of JavaScript has been enabled ("javascriptEnabled") [plugin angular-less]

node_modules/ng-zorro-antd/style/color/bezierEasing.less:110:0:
  110 │ .bezierEasingMixin();
      ╵ ^

JavaScript found within less stylesheets may be executed at build time. [https://lesscss.org/usage/#less-options]
Support for "javascriptEnabled" may be removed from the Angular CLI starting with Angular v19.
The plugin "angular-less" was triggered by this import

angular:styles/global:styles:1:8:
  1 │ @import 'src/theme.less';
    ╵         ~~~~~~~~~~~~~~~~

@simplejason After upgrading to ng17, using less packaging to report errors

@s-triar
Copy link

s-triar commented Nov 23, 2023

17.0.0-beta.0 is now available, you can try it first if you are interested. The17.0.0 version is expected to be released next week. PR related: #8151

after using this version of ng zorro, I encounter many issue regarding hydration and still not work when using new control flow @for

sorry, I type @for wrong.
here I created an issue for tooltip #8181

@yuxixi0613
Copy link

yuxixi0613 commented Jan 11, 2024

ng-17-antd@0.0.0 构建 D:\WEB\Angular\ng-17-antd

ng 构建

⠇ 建筑...▲ [警告] 已启用已弃用的 JavaScript 内联执行 (“javascriptEnabled”) [plugin angular-less]

node_modules/ng-zorro-antd/style/color/bezierEasing.less:110:0:
  110 │ .bezierEasingMixin();
      ╵ ^

在较少的样式表中找到的 JavaScript 可能会在构建时执行。[https://lesscss.org/usage/#less-options]从 Angular v19 开始,可以从 Angular CLI 中删除对“javascriptEnabled”的支持。插件“angular-less”是由此导入触发的

angular:styles/global:styles:1:8:
  1 │ @import 'src/theme.less';
    ╵         ~~~~~~~~~~~~~~~~

升级到 ng17 后,使用更少的打包来报告错误

尝试注释src/theme.less中的 @import "../node_modules/ng-zorro-antd/ng-zorro-antd.less";

@achraf-codemaster
Copy link

+1

1 similar comment
@hoangnv2810
Copy link

+1

@tritren
Copy link

tritren commented Apr 5, 2024

replace "@angular-devkit/build-angular:application" by "@angular-devkit/build-angular:browser" . That's the only way so far

@SardorSohinazarov
Copy link

[WARNING] Deprecated inline execution of JavaScript has been enabled ("javascriptEnabled") [plugin angular-less]

node_modules/ng-zorro-antd/style/color/bezierEasing.less:110:0:
  110 │ .bezierEasingMixin();
      ╵ ^

JavaScript found within less stylesheets may be executed at build time. [https://lesscss.org/usage/#less-options]
Support for "javascriptEnabled" may be removed from the Angular CLI starting with Angular v19.
The plugin "angular-less" was triggered by this import

angular:styles/global:styles:1:8:
  1 │ @import 'src/theme.less';
    ╵         ~~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests