DRAGEN: new module vc_hethom_ratio_metrics #1915
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment contains a description of changes (with reason)
CHANGELOG.md
has been updatedThere is example tool output for tools in the https://github.com/ewels/MultiQC_TestData repository or attached to this PR
Code is tested and works locally (including with
--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdEverything that can be represented with a plot instead of a table is a plot
Only linegraphs are included by default. Bargraphs can be also quickly included by setting BARGRAPHS_ENABLED
to True. The variable is in the vc_hethom_ratio_metrics.py file.
Report sections have a description and help text (with
self.add_section
)Module does not do any significant computational work
This module can be considered experimental: it can work in 2 modes by setting the variable SQUASH_SECTIONS in vc_hethom_ratio_metrics.py to True/False.
This approach looks better but is unreliable, because hiding plots can break them when resizing/reloading html
page. This bug seems to be common, at least the dragen_fastqc has the same issues.
Merging:
in PR1911, PR1912, PR1913, PR1914. But not in the dragen/utils.py, because it is the same. The main file must be also included, of course.