DRAGEN: new module SV Metrics #1913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add search regex for .sv_metrics.csv files.
Add common utils.
Add SV caller.
Just-Roma
force-pushed
the
DRAGEN-New-Module-SV-Metrics
branch
from
2da091f
to
f7ec210
Compare
Black fixing
Black again
This was referenced Apr 25, 2023
Restart the tests. The problem with "rich" lib seems to be solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment contains a description of changes (with reason)
CHANGELOG.mdhas been updatedThere is example tool output for tools in the https://github.com/ewels/MultiQC_TestData repository or attached to this PR
Code is tested and works locally (including with
--lintflag)docs/README.mdis updated with link to belowdocs/modulename.mdis createdEverything that can be represented with a plot instead of a table is a plot
Report sections have a description and help text (with
self.add_section)Only a short description. No official info, which could be used for description/help, was found.
There aren't any huge tables with > 6 columns (explain reasoning if so)
Only 5 columns are shown by default. Others (shall be no more than 4) are hidden.
Each table column has a different colour scale to its neighbour, which relates to the data (eg. if high numbers are bad, they're red)
Module does not do any significant computational work
Merging:
in PR1911, PR1912, PR1914, PR1915. But not in the dragen/utils.py, because it is the same. The main file must be also included, of course.