add sentry-qt integration for MacOS #7151
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
|
0256821 Are you sure about that - the general recommendation is to use the newest CMake version you can as it knows more about whatever situation it is being used in than older versions - at a minimum it must be newer than the compiler that is to be used... |
|
Hi @Kebap, this PR can be tested by adding sentry env. variables. Currently, I'm intentionally making macOS build to fail, for checking runtime error is getting logged on sentry. |
Yes @SlySven. I've made the changes for this currently sentry integration is controlled by WITH_SENTRY environment variable, just like we do for other modules like 3d mapper, updater, etc. I have successfully tested the variable functionality for both the cases. |
src/mudlet.pro
Outdated
| HEADERS += ../3rdparty/sentry-native/include/sentry.h | ||
| contains( DEFINES, INCLUDE_SENTRY ) { | ||
| # sentry-native is needed for MacOS builds with crash-reporting | ||
| exists("$${PWD}/../3rdparty/sentry-native/sentry-config.cmake.in") { |
There was a problem hiding this comment.
That is a CMake file, but this is a qmake project file - is there a more "neutral" file we can use for this. I know it is a bit incidental but it would appear cleaner if they don't concern themselves with each other's files. 🤷♂️
There was a problem hiding this comment.
I'm not able to think of a more "neutral" file for managing sentry specific checks. Currently, most of the checks are written taking inspiration from validations that we have for other 3rd party libraries 😅
/claim #7126
/fixes #7126