add: Sentry QT integration for windows OS #7205
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
mehulmathur001
changed the title
| @@ -202,6 +202,12 @@ git_submodule_init( | |||
| CHECK_FILE "3rdparty/edbee-lib/CMakeLists.txt" SUBMODULE_PATH | |||
| "3rdparty/edbee-lib" READABLE_NAME "edbee-lib editor widget") | |||
|
|
|||
| if(APPLE OR WIN32) | |||
There was a problem hiding this comment.
You need to import the sort of changes that were made for the MacOS one here (although we don't use CMake for Windows CI/CB builds currently. It also need to be made conditional on a USE_SENTRY like CMake variable - which is extended to both MacOs and Windows cases now I see.
| set(SENTRY_BACKEND "crashpad") | ||
| set(SENTRY_INTEGRATION_QT "ON") | ||
| set(SENTRY_INCLUDE_DIR "3rdparty/sentry-native/include") | ||
| set(SENTRY_LIBRARIES "3rdparty/sentry-native") | ||
|
|
||
| if(APPLE OR WIN32) | ||
| add_subdirectory(3rdparty/sentry-native) |
There was a problem hiding this comment.
Like the MacOS PR these all need to be conditional on something like a USE_SENTRY CMake variable.
| if(APPLE OR WIN32) | ||
| find_package(sentry REQUIRED) | ||
| endif() |
There was a problem hiding this comment.
Again, conditional on using sentry.
| @@ -557,6 +561,10 @@ if(USE_UPDATER) | |||
| target_compile_definitions(mudlet PRIVATE INCLUDE_UPDATER) | |||
| endif(USE_UPDATER) | |||
|
|
|||
| if(APPLE OR WIN32) | |||
There was a problem hiding this comment.
Again, conditional on using Sentry.
| @@ -685,3 +693,36 @@ if(UNIX AND NOT APPLE) | |||
| WORLD_READ | |||
| WORLD_EXECUTE) | |||
| endif() | |||
|
|
|||
| if(APPLE OR WIN32) | |||
There was a problem hiding this comment.
And more stuff conditional on Sentry.
|
Hi @SlySven, I'll copy the checks like we have for macOS here too. Currently I'm just trying to make the windows build pass somehow. |
Sentry QT integration for windows OS