Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty outlines and display a message in the console. #829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

francodgstn
Copy link
Contributor

I needed a quick workaround for the issue #789 (and #708)
It doesn't address the root cause, why some outlines are empty, but at least it allows to export the ImageJ ROI file.

I'm not used to python, you might want to adjust the code.

@francodgstn
Copy link
Contributor Author

@mrariden I see you have the bug #789 assigned, any chance to review my change?

@carsen-stringer
Copy link
Member

did the other PR fix this?

@francodgstn
Copy link
Contributor Author

Hi, not exactly. The other PR was just to ignore empty line in the imagej_roi_converter.py.
Here the idea is to do not generate those at all and give feedback in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants