Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make GPU check fix #706

Merged
merged 1 commit into from
May 14, 2023
Merged

Conversation

mrariden
Copy link
Collaborator

Per #705, an image with lots of bad masks will attempt to call torch.cuda.get_device_properties(0) in dynamics.remove_bad_flow_masks() without regard for the GPU status set by the use_gpu flag. @alix-simon 's fix is to check the flag in line 580.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #706 (de61b8b) into main (b709064) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   37.40%   37.38%   -0.02%     
==========================================
  Files          20       20              
  Lines        5355     5355              
==========================================
- Hits         2003     2002       -1     
- Misses       3352     3353       +1     
Impacted Files Coverage Δ
cellpose/dynamics.py 54.09% <100.00%> (ø)

... and 1 file with indirect coverage changes

@carsen-stringer carsen-stringer merged commit ca88d6a into MouseLand:main May 14, 2023
10 checks passed
@mrariden mrariden deleted the gpu_check_flow_masks branch May 16, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants