New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.14.x] Rewrite docs for Registries #297
Conversation
first review, and it seems that i do not have the hang of it. Got most stuff twice in each... sorry for the hassle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks pretty good, I've only got two small comments. Although I've never used the @ ObjectHolder so I can't give any feedback on that part.
As 1.14.x is moving into out-of-support, I am closing this PR. See the updated PR for 1.15.x. |
As said to me, 1.14.x is the branch to currently target. Since 1.14.x is essentially the same to 1.15.x in regards to registries, the reviews from the other branch will apply to this branch. |
I might have to make a PR once this is merged into 1.15.x, to change the section on |
Rewrote [Concepts > Registries]:
GameRegistry.register
DeferredRegister
is first and foremostObjectHolder
rules from block of text to rules list (TIL thatfinal
only matters if the class and not the field has@ObjectHolder
)Issue #275 can be closed, and I think the related issue #85 can be closed, since the issue is from long, long ago (2017), and both points are resolved:
GameRegistry.register
inpreInit
is non-existent at this point; andRegistryBuilder
is only used when a modder wants to adds a registry, which is not common I would assume.