Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the mentioning of GameRegistry.register #304

Closed
wants to merge 1 commit into from

Conversation

3TUSK
Copy link
Contributor

@3TUSK 3TUSK commented Jun 19, 2020

It has been gone for quite a long while now and leaving it hear serves for no purpose.

It has been gone for quite a long while now and leaving it hear serves for no purpose.
Copy link
Contributor

@Aeltumn Aeltumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes are fine but I don't know if this information needs to be removed. The documentation already states that this is not the correct method. I don't know if there's any harm in keeping this information in there.

@3TUSK
Copy link
Contributor Author

3TUSK commented Jun 28, 2020

The documentation already states that this is not the correct method.

Back in 1.12.x, trying to call this would already give you a compile error (it was private). You should have had enough time to migrate to the RegistryEvent.Register<T>. FWIW, that paragraph in question was also in the 1.12.x branch; it is fair to assume that that paragraph has finished its mission of smoothing transition.

I don't know if there's any harm in keeping this information in there.

Personally, I do not see if there is any good, either. One can only hope that no one asks "where did my method go?!" and ignores the rest of article…

@sciwhiz12
Copy link
Contributor

Just commenting that #297 also removes the mentioning of GameRegistry.

@3TUSK
Copy link
Contributor Author

3TUSK commented Jun 28, 2020

Interesting, guess I am going to close mine to avoid clash. Thanks for heads up sciwhiz12!

@3TUSK 3TUSK closed this Jun 28, 2020
@3TUSK 3TUSK deleted the patch-1 branch June 28, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants