Version v11.14.3 - Hotfix getMinimumGasTotalInHexWei error when gasEstimateType === "fee_market" #24292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arket" (#24287) ## **Description** See Issue #24263 for investigation details This will be a hotfix targeting v11.14.3 ## **Related issues** Fixes: #24263 ## **Manual testing steps** One way to repro is by adding the Scroll Sepholia Testnet (see: https://docs.scroll.io/en/user-guide/setup/), then using our test dapp > Send Eth > Send For other repro methods, please refer to the related issue ticket ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
Builds ready [e362d74]
Page Load Metrics (561 ± 406 ms)
|
|
I was able to reproduce the bug (2 times, both times on Scroll network) on the current production 11.14.2: prodErr.movI can't reproduce it on current build 11.14.3 (chrome, Firefox) - Scroll, Scroll Sepolia, Metis https://app.aave.com/?marketName=proto_metis_v3, Polygon zkEVM: 11.14.3.mov |
sleepytanya
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfix to resolve issue with occurrences from v11.14.0
Cherry-picked from #24287
Solution collab'd with @matthewwalsh0
Investigation by: @anaamolnar, @bergeron, @bschorchit, @digiwand, @danjm, @matthewwalsh0
Related issues
Fixes: #24263
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist