Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.14.3 - Hotfix getMinimumGasTotalInHexWei error when gasEstimateType === "fee_market" #24288

Closed
wants to merge 2 commits into from

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Apr 29, 2024

Description

Hotfix to resolve issue with occurrences from v11.14.0

See Issue #24263 for investigation details

Solution collab'd with @matthewwalsh0

Investigation by: @anaamolnar, @bergeron, @bschorchit, @digiwand, @danjm, @matthewwalsh0

Related issues

Fixes: #24263

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand
Copy link
Contributor Author

closing to redo with cherry-picked PR

@digiwand digiwand closed this Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@digiwand digiwand deleted the Version-v11.14.3 branch April 29, 2024 17:28
@digiwand
Copy link
Contributor Author

see: #24292

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant