Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkbox background color #24262

Merged
merged 5 commits into from
Apr 30, 2024
Merged

fix: checkbox background color #24262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
affbb24
fix: checkbox background color to use background default instead of t…
georgewrmarshall Apr 26, 2024
bf65ed2
chore: updating snapshots
georgewrmarshall Apr 26, 2024
96f425d
Merge branch 'develop' into fix/checkbox-background
georgewrmarshall Apr 26, 2024
a618c81
Merge branch 'develop' into fix/checkbox-background
georgewrmarshall Apr 30, 2024
c0acf58
Merge branch 'develop' into fix/checkbox-background
georgewrmarshall Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/components/app/modals/eth-sign-modal/__snapshots__/eth-sign-modal.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ exports[`Eth Sign Modal should match snapshot 1`] = `
class="mm-checkbox__input-wrapper"
>
<input
class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-2 mm-box--display-flex mm-box--background-color-transparent mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid"
class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-2 mm-box--display-flex mm-box--background-color-background-default mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid"
id="eth-sign-checkbox"
title="I understand that I can lose all of my funds and NFTs if I enable eth_sign requests. "
type="checkbox"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating snapshots

Expand Down
2 changes: 1 addition & 1 deletion ui/components/component-library/checkbox/__snapshots__/checkbox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`Checkbox should render the Checkbox without crashing 1`] = `
class="mm-checkbox__input-wrapper"
>
<input
class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-0 mm-box--display-flex mm-box--background-color-transparent mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid"
class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-0 mm-box--display-flex mm-box--background-color-background-default mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid"
type="checkbox"
/>
</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating snapshots

Expand Down
2 changes: 1 addition & 1 deletion ui/components/component-library/checkbox/checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const Checkbox: CheckboxComponent = React.forwardRef(
backgroundColor={
isChecked || isIndeterminate
? BackgroundColor.primaryDefault
: BackgroundColor.transparent
: BackgroundColor.backgroundDefault
}
borderColor={
isChecked || isIndeterminate
Expand Down