fix: checkbox background color #24262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
force-pushed
the
fix/checkbox-background
branch
from
f00c19c
to
affbb24
Compare
| @@ -66,7 +66,7 @@ exports[`Eth Sign Modal should match snapshot 1`] = ` | |||
| class="mm-checkbox__input-wrapper" | |||
| > | |||
| <input | |||
| class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-2 mm-box--display-flex mm-box--background-color-transparent mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid" | |||
| class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-2 mm-box--display-flex mm-box--background-color-background-default mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid" | |||
| id="eth-sign-checkbox" | |||
| title="I understand that I can lose all of my funds and NFTs if I enable eth_sign requests. " | |||
| type="checkbox" | |||
There was a problem hiding this comment.
updating snapshots
| @@ -9,7 +9,7 @@ exports[`Checkbox should render the Checkbox without crashing 1`] = ` | |||
| class="mm-checkbox__input-wrapper" | |||
| > | |||
| <input | |||
| class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-0 mm-box--display-flex mm-box--background-color-transparent mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid" | |||
| class="mm-box mm-checkbox__input mm-box--margin-0 mm-box--margin-right-0 mm-box--display-flex mm-box--background-color-background-default mm-box--rounded-sm mm-box--border-color-border-default mm-box--border-width-2 box--border-style-solid" | |||
| type="checkbox" | |||
| /> | |||
| </span> | |||
There was a problem hiding this comment.
updating snapshots
13 tasks
garrettbear
approved these changes
Apr 26, 2024
darkwing
approved these changes
Apr 26, 2024
Builds ready [c0acf58]
Page Load Metrics (297 ± 336 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-11.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the background color of the checkbox component from transparent to white across the MetaMask extension. The motivation behind this change is to enhance the visibility and contrast of the checkbox against various backgrounds, and align it with the Figma component
Component in Figma showing background default
Related issues
Fixes: N/A
Manual testing steps
To ensure the checkbox component's background color update is correctly implemented:
Screenshots/Recordings
Before
before720.mov
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist
This PR represents a significant improvement in the usability and accessibility of the MetaMask extension, ensuring that all users can easily interact with and visually distinguish the checkbox component, regardless of the background.