Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Reorganize e2e tests repo part2 #24238

Merged
merged 12 commits into from Apr 29, 2024
Merged

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Apr 25, 2024

Description

Following #23398, This PR is the second part to reorganize the test/e2e repository to create a structure that is both well-organized and easy to navigate.

Open in GitHub Codespaces

Related issues

Fixes: #23296

Manual testing steps

Check if the organization is logical.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform e2e-test End to end test for the MetaMask extension labels Apr 25, 2024
@chloeYue chloeYue self-assigned this Apr 25, 2024
@chloeYue chloeYue requested a review from a team as a code owner April 25, 2024 09:54
@chloeYue chloeYue marked this pull request as draft April 25, 2024 09:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title Reorganiz e2e tests part2 test: Reorganize e2e tests part2 Apr 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4a51a26]
Page Load Metrics (1150 ± 725 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682371095426
domContentLoaded989222110
load55418311501510725
domInteractive989222110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [eff8a1f]
Page Load Metrics (624 ± 545 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57145812110
domContentLoaded85715136
load4534316241135545
domInteractive85715136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (bbb372f) to head (eff8a1f).

❗ Current head eff8a1f differs from pull request most recent head 3ab6fe1. Consider uploading reports for the commit 3ab6fe1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24238      +/-   ##
===========================================
- Coverage    67.28%   67.24%   -0.04%     
===========================================
  Files         1275     1271       -4     
  Lines        49707    49623      -84     
  Branches     12916    12908       -8     
===========================================
- Hits         33442    33367      -75     
+ Misses       16265    16256       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chloeYue chloeYue marked this pull request as ready for review April 29, 2024 07:58
@chloeYue chloeYue changed the title test: Reorganize e2e tests part2 test: Reorganize e2e tests repo part2 Apr 29, 2024
DDDDDanica
DDDDDanica previously approved these changes Apr 29, 2024
@DDDDDanica
Copy link
Contributor

LGTM ! Thanks for the work !

@metamaskbot
Copy link
Collaborator

Builds ready [3ab6fe1]
Page Load Metrics (1541 ± 781 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691681112813
domContentLoaded115120115
load60369615411626781
domInteractive115120115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica merged commit 4caa85f into develop Apr 29, 2024
70 of 71 checks passed
@DDDDDanica DDDDDanica deleted the chloe-reorganize-e2e-2 branch April 29, 2024 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@metamaskbot metamaskbot added the release-11.17.0 Issue or pull request that will be included in release 11.17.0 label Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e2e-test End to end test for the MetaMask extension release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[E2E] Refacto e2e tests to make navigation easier
4 participants