Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(000): sort e2e tests and related test folder #23037

Closed
wants to merge 3 commits into from

Conversation

DDDDDanica
Copy link
Contributor

Description

As recommended by @dan437 , this PR aims to sort out e2e tests folder and tests under it to make it easier to search and contribute.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica force-pushed the feature/sort-e2e branch 12 times, most recently from 76fa7b7 to 6e259c6 Compare February 22, 2024 18:34
@DDDDDanica DDDDDanica force-pushed the feature/sort-e2e branch 2 times, most recently from 46b7739 to 7a99b37 Compare February 27, 2024 16:36
@DDDDDanica DDDDDanica changed the title feat(000): sort e2e tests and related test folder WIP: feat(000): sort e2e tests and related test folder Mar 4, 2024
@chloeYue
Copy link
Contributor

Closing this one because it will be done in #24238 and #23398

@chloeYue chloeYue closed this Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants