Skip to content

Commit

Permalink
fix: PW test for MMI (#24279)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Test flow needed to be updated after a UI change in the "connection
flow" for MM, related with this PR:
#23557


## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
zone-live committed Apr 30, 2024
1 parent 9c50ce2 commit 60f4c8b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions test/e2e/mmi/pageObjects/mmi-dummyApp-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ export class DummyAppPage {
await popup1.waitForLoadState();
// Check which account is selected and select if required
await popup1.locator('.check-box__indeterminate');
// await popup1.locator('text=Custody Ac... (0x8b2...b3ad)').click()
await popup1.locator('button:has-text("Next")').click();
await popup1.locator('button:has-text("Connect")').click();
await popup1.locator('button:has-text("Confirm")').click();
await popup1.close();
}

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/mmi/specs/navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ test.describe('MMI Navigation', () => {
context,
mainMenuPage.page,
'learn more',
learnMoreArticles,
'https://support.metamask.io/token-swaps/what-is-smart-swaps/',
);

await mainMenuPage.selectSettings('Security & privacy');
Expand Down

0 comments on commit 60f4c8b

Please sign in to comment.