Skip to content

Commit

Permalink
fix: update to transaction-controller 28.1.1 to fix NFT mint simulati…
Browse files Browse the repository at this point in the history
…on (#24306)

## **Description**
Update transaction-controller core package to bring in this fix to NFT
mint simulation: MetaMask/core#4217

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24306?quickstart=1)

## **Related issues**

Fixes: #24251

## **Manual testing steps**

1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h 
2. Try minting the nft
3. Simulation should work and show the nft in the "You receive" section.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

(Simulation Failed message)

### **After**


![image](https://github.com/MetaMask/metamask-extension/assets/507015/ded0173a-088c-4f12-b3b6-09b823db7756)

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
dbrans committed Apr 30, 2024
1 parent 8a0e455 commit 9c50ce2
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 16 deletions.
1 change: 1 addition & 0 deletions app/scripts/lib/setupSentry.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export const SENTRY_BACKGROUND_STATE = {
gasEstimateType: true,
gasFeeEstimates: true,
gasFeeEstimatesByChainId: true,
nonRPCGasFeeApisDisabled: false,
},
KeyringController: {
isUnlocked: true,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
"@metamask/snaps-rpc-methods": "^8.0.0",
"@metamask/snaps-sdk": "^4.0.1",
"@metamask/snaps-utils": "^7.1.1",
"@metamask/transaction-controller": "^28.1.0",
"@metamask/transaction-controller": "^28.1.1",
"@metamask/user-operation-controller": "^8.0.1",
"@metamask/utils": "^8.2.1",
"@ngraveio/bc-ur": "^1.1.12",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
"gasFeeEstimatesByChainId": {},
"gasFeeEstimates": {},
"estimatedGasFeeTimeBounds": {},
"gasEstimateType": "none"
"gasEstimateType": "none",
"nonRPCGasFeeApisDisabled": "boolean"
},
"KeyringController": {
"isUnlocked": false,
Expand Down Expand Up @@ -146,6 +147,7 @@
"dismissSeedBackUpReminder": true,
"disabledRpcMethodPreferences": { "eth_sign": false },
"useMultiAccountBalanceChecker": true,
"hasDismissedOpenSeaToBlockaidBanner": false,
"useSafeChainsListValidation": "boolean",
"useTokenDetection": false,
"useNftDetection": false,
Expand All @@ -157,7 +159,6 @@
"addSnapAccountEnabled": "boolean",
"advancedGasFee": {},
"featureFlags": {},
"hasDismissedOpenSeaToBlockaidBanner": false,
"incomingTransactionsPreferences": {},
"knownMethodData": "object",
"currentLocale": "en",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"isUnlocked": false,
"isAccountMenuOpen": false,
"isNetworkMenuOpen": false,
"identities": "object",
"internalAccounts": { "accounts": "object", "selectedAccount": "string" },
"transactions": "object",
"networkConfigurations": "object",
Expand Down Expand Up @@ -75,7 +74,6 @@
"showAccountBanner": true,
"trezorModel": null,
"hadAdvancedGasFeesSetPriorToMigration92_3": false,
"hasDismissedOpenSeaToBlockaidBanner": false,
"nftsDropdownState": {},
"termsOfUseLastAgreed": "number",
"qrHardware": {},
Expand Down Expand Up @@ -103,6 +101,7 @@
"dismissSeedBackUpReminder": true,
"disabledRpcMethodPreferences": { "eth_sign": false },
"useMultiAccountBalanceChecker": true,
"hasDismissedOpenSeaToBlockaidBanner": false,
"useSafeChainsListValidation": true,
"useTokenDetection": false,
"useNftDetection": false,
Expand All @@ -113,6 +112,7 @@
"addSnapAccountEnabled": "boolean",
"advancedGasFee": {},
"incomingTransactionsPreferences": {},
"identities": "object",
"lostIdentities": "object",
"forgottenPassword": false,
"ipfsGateway": "string",
Expand Down Expand Up @@ -149,6 +149,7 @@
"gasFeeEstimates": {},
"estimatedGasFeeTimeBounds": {},
"gasEstimateType": "none",
"nonRPCGasFeeApisDisabled": "boolean",
"tokenList": "object",
"tokensChainsCache": {},
"preventPollingOnNetworkRestart": false,
Expand Down
22 changes: 11 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5324,12 +5324,12 @@ __metadata:
languageName: node
linkType: hard

"@metamask/gas-fee-controller@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/gas-fee-controller@npm:15.0.0"
"@metamask/gas-fee-controller@npm:^15.0.0, @metamask/gas-fee-controller@npm:^15.1.0":
version: 15.1.0
resolution: "@metamask/gas-fee-controller@npm:15.1.0"
dependencies:
"@metamask/base-controller": "npm:^5.0.1"
"@metamask/controller-utils": "npm:^9.0.2"
"@metamask/controller-utils": "npm:^9.1.0"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/ethjs-unit": "npm:^0.3.0"
"@metamask/network-controller": "npm:^18.1.0"
Expand All @@ -5341,7 +5341,7 @@ __metadata:
uuid: "npm:^8.3.2"
peerDependencies:
"@metamask/network-controller": ^18.0.0
checksum: f4ca2ca113d543d3f1282df8e171d06a8cd2ce99ad7df54d1796416f9c93dd62d998af09c124fbd5138b4592602c958d30c9fe03a8ed06ccaecd8745cd6a3913
checksum: 42e3dc470b9e075c2eff48f9272c5f0cc4f0a3357873b74301c928c227344ff670756d748fca95ae395dbedb72ce848cb6812fb07eb636410cd4db22c35f2060
languageName: node
linkType: hard

Expand Down Expand Up @@ -6425,9 +6425,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/transaction-controller@npm:^28.1.0":
version: 28.1.0
resolution: "@metamask/transaction-controller@npm:28.1.0"
"@metamask/transaction-controller@npm:^28.1.0, @metamask/transaction-controller@npm:^28.1.1":
version: 28.1.1
resolution: "@metamask/transaction-controller@npm:28.1.1"
dependencies:
"@ethereumjs/common": "npm:^3.2.0"
"@ethereumjs/tx": "npm:^4.2.0"
Expand All @@ -6439,7 +6439,7 @@ __metadata:
"@metamask/base-controller": "npm:^5.0.1"
"@metamask/controller-utils": "npm:^9.1.0"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/gas-fee-controller": "npm:^15.0.0"
"@metamask/gas-fee-controller": "npm:^15.1.0"
"@metamask/metamask-eth-abis": "npm:^3.1.1"
"@metamask/network-controller": "npm:^18.1.0"
"@metamask/rpc-errors": "npm:^6.2.1"
Expand All @@ -6456,7 +6456,7 @@ __metadata:
"@metamask/approval-controller": ^6.0.0
"@metamask/gas-fee-controller": ^15.0.0
"@metamask/network-controller": ^18.0.0
checksum: e043b74ba17ccf702226bf7bad4bd251d35485fc7d90da2108a5d188a0016bd1ed65a4b63e29c6395161c02964ac36936493d8cee43bfad147132fca17344df3
checksum: 01e6f0e1431e56cc0ef986cbfa99cf37e0a44aade14419c69d815be77847bb33b43049b90c6e6961bb5070ecfe1420c893db8a68c0fd6977d5ec28d9853d6554
languageName: node
linkType: hard

Expand Down Expand Up @@ -25555,7 +25555,7 @@ __metadata:
"@metamask/snaps-utils": "npm:^7.1.1"
"@metamask/test-bundler": "npm:^1.0.0"
"@metamask/test-dapp": "npm:^8.4.0"
"@metamask/transaction-controller": "npm:^28.1.0"
"@metamask/transaction-controller": "npm:^28.1.1"
"@metamask/user-operation-controller": "npm:^8.0.1"
"@metamask/utils": "npm:^8.2.1"
"@ngraveio/bc-ur": "npm:^1.1.12"
Expand Down

0 comments on commit 9c50ce2

Please sign in to comment.