Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CloudObjectStoreContainerForm test #9178

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented May 6, 2024

yarn run jest -t 'Cloud Object Store Container form component' --testPathPattern app/javascript/spec/cloud-object-store-container-form/cloud-object-store-container-form.spec.js

Before

 PASS  app/javascript/spec/cloud-object-store-container-form/cloud-object-store-container-form.spec.js
  Cloud Object Store Container form component
    ✓ should render add cloud object store container form (94ms)
    ✓ should add Openstack cloud object store container (31ms)
    ✓ should add Amazon cloud object store container (19ms)

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to Select inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in Select (created by Select)
        in Select (created by SelectWithOnChange)
        in SelectWithOnChange (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CloudObjectStoreContainerForm)
        in CloudObjectStoreContainerForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to Select inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in Select (created by Select)
        in Select (created by SelectWithOnChange)
        in SelectWithOnChange (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CloudObjectStoreContainerForm)
        in CloudObjectStoreContainerForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to Select inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in Select (created by Select)
        in Select (created by SelectWithOnChange)
        in SelectWithOnChange (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CloudObjectStoreContainerForm)
        in CloudObjectStoreContainerForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to Select inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in Select (created by Select)
        in Select (created by SelectWithOnChange)
        in SelectWithOnChange (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CloudObjectStoreContainerForm)
        in CloudObjectStoreContainerForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   3 passed, 3 total
Time:        3.766s

After

 PASS  app/javascript/spec/cloud-object-store-container-form/cloud-object-store-container-form.spec.js
  Cloud Object Store Container form component
    ✓ should render add cloud object store container form (90ms)
    ✓ should add Openstack cloud object store container (33ms)
    ✓ should add Amazon cloud object store container (22ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   3 passed, 3 total
Time:        4.409s

@jeffibm jeffibm added the test label May 6, 2024
@jeffibm jeffibm requested a review from a team as a code owner May 6, 2024 08:50
@jeffibm jeffibm mentioned this pull request May 6, 2024
35 tasks
@GilbertCherrie
Copy link
Member

@jeffibm Please fix the conflicts and repush

@jeffibm jeffibm force-pushed the fix-cloud-object-store-container-form-test branch from f199ae1 to ec6787a Compare May 16, 2024 03:28
@jeffibm jeffibm force-pushed the fix-cloud-object-store-container-form-test branch from f75ef73 to 823a8d3 Compare May 16, 2024 06:01
@miq-bot
Copy link
Member

miq-bot commented May 16, 2024

Checked commit jeffbonson@823a8d3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@GilbertCherrie GilbertCherrie merged commit 9d401cb into ManageIQ:master May 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants