compiling under Ubuntu 20.04 #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suuman
pushed a commit
to suuman/Kimera-VIO-ROS
that referenced
this pull request
Jun 25, 2021
Fix/tesse cam params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment compilation of GTSAM fails under Ubuntu 20.04 due to the use of the "master" branch, which is outdated and does not compile under later versions of cmake, see #115
This PR fixes this by using the GTSAM 4.0.3 tag instead of the master branch.
Further, the minimum requirement for cmake is set to 3.5.0 to suppress warning messages related to CMP0048.
Tested to be compiling under Ubuntu 16.04, 18.04, and 20.04.
Will break Ubuntu 14.04 (trusty), which uses cmake 2.8.x. (The workaround is to upgrade cmake:
https://askubuntu.com/questions/610291/how-to-install-cmake-3-2-on-ubuntu)