Swap ordering of thread configuration in Sycl #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
artv3
requested review from
rhornung67,
mdavis36,
rchen20,
MrBurmark,
johnbowen42 and
long58
rchen20
approved these changes
Apr 17, 2024
johnbowen42
approved these changes
Apr 17, 2024
long58
approved these changes
Apr 17, 2024
|
@rhornung67 , did you want to take a look at this PR? Or should I just merge? |
rhornung67
reviewed
Apr 30, 2024
@rhornung67 I just pushed up a note on the docs. Please let me know if any adjustments are needed. I held off on commenting about kernel as we need to double check and we can follow up after. I also don't have a sense on performance changes as I had not looked at timings and the kernels in the raja perf suite were generating incorrect answers prior to this change. |
rhornung67
reviewed
Apr 30, 2024
rhornung67
reviewed
Apr 30, 2024
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
rhornung67
approved these changes
Apr 30, 2024
|
@artv3 if you don't want to keep the branch, please delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sycl uses the outermost index as the fastest, this change enables consistency when using RAJA::launch with other device back ends.
For reference this page has a good description on thread indexing using sycl:
https://www.intel.com/content/www/us/en/docs/dpcpp-compatibility-tool/developer-guide-reference/2023-2/cuda-and-sycl-programming-model-comparison.html
See the Thread Indexing section.