-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sycl shared memory kernels #439
Conversation
Hi @rhornung67, I believe I have this working now. We will need to update RAJA though. |
@rhornung67 did you want to take a look at this MR as well? |
src/apps/CONVECTION3DPA.hpp
Outdated
|
||
template < size_t block_size > | ||
void runCudaVariantImpl(VariantID vid); | ||
template < size_t block_size > | ||
void runHipVariantImpl(VariantID vid); | ||
template < size_t block_size > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been naming the template parameter for the SYCL methods work_group_size
, in the header and implementation files, since that is the SYCL terminology. Please do that for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template parameter name change request for consistency.
Sounds good @rhornung67 , just pushed up the changes. I also pushed up an update to RAJA as we need the SYCL thread ordering fix we merged in yesterday. |
Addresses:
#429
Kernel list
Will require updating RAJA due to bugfix. See: LLNL/RAJA#1626 and LLNL/RAJA#1628