Sycl shared memory kernels #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rhornung67, I believe I have this working now. We will need to update RAJA though. |
MrBurmark
approved these changes
Apr 22, 2024
|
@rhornung67 did you want to take a look at this MR as well? |
rhornung67
reviewed
Apr 30, 2024
src/apps/CONVECTION3DPA.hpp
Outdated
|
|
||
| template < size_t block_size > | ||
| void runCudaVariantImpl(VariantID vid); | ||
| template < size_t block_size > | ||
| void runHipVariantImpl(VariantID vid); | ||
| template < size_t block_size > |
There was a problem hiding this comment.
I've been naming the template parameter for the SYCL methods work_group_size, in the header and implementation files, since that is the SYCL terminology. Please do that for consistency.
rhornung67
reviewed
Apr 30, 2024
Sounds good @rhornung67 , just pushed up the changes. I also pushed up an update to RAJA as we need the SYCL thread ordering fix we merged in yesterday. |
rhornung67
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
#429
Kernel list
Will require updating RAJA due to bugfix. See: LLNL/RAJA#1626 and LLNL/RAJA#1628